Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator re-staking #297

Merged
merged 13 commits into from
Nov 15, 2023
Merged

Validator re-staking #297

merged 13 commits into from
Nov 15, 2023

Conversation

salman01zp
Copy link
Contributor

@salman01zp salman01zp commented Nov 8, 2023 •
edited
Loading

Summary of changes
Changes introduced in this pull request:

  • Simple Re-staking implementation

    • The account should be a validator account
    • User chooses to re-stake Full or Custom amount.
    • Re-stake value should meet the minimum value requirement to opt for the role.
    • The user can chill, unbound, and withdraw_unbound only when he has opted out of all the services and the role is cleared.

  • Update and add new tests.

Note

  • chill , unbound , withdraw_unbound calls from staking-pallet are blocked and are only allowed through roles pallet
  • The slashing part will be covered in separate PR.

Reference issue to close (if applicable)

Closes #291

@salman01zp salman01zp marked this pull request as ready for review November 15, 2023 05:04
@salman01zp salman01zp requested a review from shekohex November 15, 2023 05:05
1xstj
1xstj reviewed Nov 15, 2023
View reviewed changes
pallets/roles/src/lib.rs Outdated Show resolved Hide resolved
pallets/roles/src/lib.rs Outdated Show resolved Hide resolved
pallets/roles/src/lib.rs Outdated Show resolved Hide resolved
pallets/roles/src/impls.rs Show resolved Hide resolved
pallets/roles/src/impls.rs Show resolved Hide resolved
@1xstj 1xstj merged commit 1ab7dad into main Nov 15, 2023
8 checks passed
@1xstj 1xstj deleted the salman/re-staking branch November 15, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1xstj 1xstj 1xstj approved these changes

@drewstone drewstone Awaiting requested review from drewstone drewstone is a code owner

@tbraun96 tbraun96 Awaiting requested review from tbraun96

@shekohex shekohex Awaiting requested review from shekohex shekohex is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] Implement re-staking model for roles pallet
2 participants
@salman01zp @1xstj